OSVersion() -> WindowsVersion()

josku_x · Post by **josku_x** » Thu May 25, 2006 3:18 pm

Hello!

I see that OSVersion() is only for windows and it returns the windows version. So OSVersion() sounds a bit confusing, the user might think it would work for other platforms as well if he doesn't look the helpfile.

So, I think to make more readable and clearer code, the OSVersion() function should be renamed to WindowVersion() or something like that.

Nothing special though.

Tranquil · Post by **Tranquil** » Sat May 27, 2006 4:27 am

Maybe this command is supported on other systems in the near future. Should it be renamed then again!? For me this commandname is clear couse the docs says all.

josku_x · Post by **josku_x** » Sat May 27, 2006 8:34 am

Tranquil wrote:Maybe this command is supported on other systems in the near future. Should it be renamed then again!? For me this commandname is clear couse the docs says all.

I knew this gets a reply like this.

But as I said nothing special though

Perhaps I should make a request for a *cross-platform* OSVersion(), but I don't need it right know.

MVXA · Post by **MVXA** » Sun May 28, 2006 1:26 pm

OSVersion() on Linux should return the kernel version or name of distro..

josku_x · Post by **josku_x** » Sun May 28, 2006 2:40 pm

MVXA wrote:OSVersion() on Linux should return the kernel version or name of distro..

From the helpfile:

Syntax
Result = OSVersion()
Description

Returns the OS Version on which the program has been launched. It could help to enabled/disable automatically some features depending of the running OS.

'Result' can be one of the following values:
#PB_OS_Windows_NT3_51
#PB_OS_Windows_95
#PB_OS_Windows_NT_4
#PB_OS_Windows_98
#PB_OS_Windows_ME
#PB_OS_Windows_2000
#PB_OS_Windows_XP
#PB_OS_Windows_Server_2003
#PB_OS_Windows_Future ; New Windows version (not existent when the program was written)

...........

Supported OS

Windows

DarkDragon · Post by **DarkDragon** » Sun May 28, 2006 3:04 pm

Learn how to interpret a sentence in english please.

MVXA meant in the future when there's PB 4.0 for Linux.

josku_x · Post by **josku_x** » Sun May 28, 2006 3:13 pm

DarkDragon wrote:Learn how to interpret a sentence in english please.

MVXA meant in the future when there's PB 4.0 for Linux.

He didn't say anything from PB4 for linux, that's why I thought he means 'now'

Post by **Fred** » Mon May 29, 2006 10:48 am

It's not because the command is Windows only (for now), than it should be renamed... What's the sens in that ?

josku_x · Post by **josku_x** » Mon May 29, 2006 12:25 pm

Fred wrote:It's not because the command is Windows only (for now), than it should be renamed... What's the sens in that ?

Perhaps there's no sense in that, but for clearer code? But as I said, nothing special. Just ignore this, I can live with my macro

Code: Select all

Macro WindowsVersion()
 OSVersion()
EndMacro

dracflamloc · Post by **dracflamloc** » Tue May 30, 2006 2:54 am

Clearer code? It most certainly doesnt clear up code. Especially with your Macro. That adds 3 more lines...

Btw I wouldnt bother asking for a command to be renamed. Its a useless flood of the feature requests.

blueznl · Post by **blueznl** » Tue May 30, 2006 7:29 am

not sure, dracflamloc, sometimes it makes sense

eventgadgetid() -> eventgadget, to name just an example, is a change that makes A LOT OF sense in pb4