[Done] PB 572 b1: IDE Formdesigner display problem setting parent

[Kurzer]

PB 572 b1 x64 / Windows 7 x64 SP1 classic design

IDE / formdesigner: There is a small display problem in the assignment dialog for setting a parent object. At least for the german version of PB.



Greetings
Kurzer

[Sicro]

I have adjusted the size of the gadgets and the window.
Under Linux, it looks good for me now. Unfortunately I can't test it under Windows.

Before the fix:


After the fix:


PR on GitHub: https://github.com/fantaisie-software/purebasic/pull/50

[Kurzer]

PB 5.72 b2 x64:

It looks better now, but have much free space to the left.
Also the height of the comboxboxes is to big. Maybe its caused by the DPI adjusting within the FormDesigner? My desktopscale is set to 125%.

[Sicro]

I think it is better to always use the Dialog-Lib when it comes to cross-platform GUI creation.
In the next days I will create the window using the Dialog-Lib and post the code here for testing.

[Sicro]

How it looks now under my Linux:



Here is the code for testing. I hope the window always looks good now.

Code: Select all

Runtime Enumeration Window
  #WINDOW_Form_Parent
EndEnumeration

Runtime Enumeration Gadget
  #GADGET_Form_Parent_Select
  #GADGET_Form_Parent_SelectItem
  #GADGET_Form_Parent_Cancel
  #GADGET_Form_Parent_OK
EndEnumeration

XML$ = "<?xml version='1.0' encoding='UTF-8'?>" +
"<dialogs>" +
"  <window flags='#PB_Window_SystemMenu | #PB_Window_ScreenCentered' text='Übergeordnet' id='#WINDOW_Form_Parent'>" +
"    <vbox spacing='10'>" +
"      <empty/>" +
"      <gridbox colspacing='15' rowspacing='15' columns='4'>" +
"        <empty/>" +
"        <text text='Übergeordnet' flags='#PB_Text_Right'/>" +
"        <combobox height='22' width='250' id='#GADGET_Form_Parent_Select'/>" +
"        <empty/>" +
"        <empty/>" +
"        <text text='Übergeordnetes Element' flags='#PB_Text_Right'/>" +
"        <combobox height='22' width='250' id='#GADGET_Form_Parent_SelectItem'/>" +
"        <empty/>" +
"      </gridbox>" +
"      <empty/>" +
"      <hbox>" +
"        <empty/>" +
"        <button text='Abbruch' id='#GADGET_Form_Parent_Cancel'/>" +
"        <button text='OK' id='#GADGET_Form_Parent_OK'/>" +
"        <empty/>" +
"      </hbox>" +
"      <empty/>" +
"    </vbox>" +
"  </window>" +
"</dialogs>"

If ParseXML(0, XML$) And XMLStatus(0) = #PB_XML_Success
  
  If CreateDialog(0) And OpenXMLDialog(0, 0, "")
    
    For i = 0 To 2
      AddGadgetItem(#GADGET_Form_Parent_Select, -1, "Select_" + i)
      AddGadgetItem(#GADGET_Form_Parent_SelectItem, -1, "SelectItem_" + i)
    Next
    
    Repeat
      Event = WaitWindowEvent()
    Until Event = #PB_Event_CloseWindow
    
  Else
    Debug "Dialog error: " + DialogError(0)
  EndIf
Else
  Debug "XML error: " + XMLError(0) + " (Line: " + XMLErrorLine(0) + ")"
EndIf

[Kurzer]

Sorry Sicro,
I have unfortunately only seen your PN today.
The dialogue looks very good on my system.



Kurzer

[Kurzer]

In the current beta 3, the dialogue unfortunately looks worse again.

There are no line breaks in the labels, but the combo boxes are too high again on my 125% scaled system and also the left border to the fixed frame is too wide.



According to the beta 3 announcement this bug should be fixed:

- Fix display errors in window '#WINDOW_Form_Parent' of the FormDesigner (Sicro) https://github.com/fantaisie-software/purebasic/pull/50

Greetings,
"Shorty"

[Sicro]

In the current beta 3, the dialogue unfortunately looks worse again.

I have not yet found the time to integrate the Dialog-Lib variant. Tomorrow I will have time for it.

According to the beta 3 announcement this bug should be fixed:

- Fix display errors in window '#WINDOW_Form_Parent' of the FormDesigner (Sicro) https://github.com/fantaisie-software/purebasic/pull/50

The mentioned pull request on GitHub is old and has already been integrated in Beta 2.

[Kurzer]

The mentioned pull request on GitHub is old and has already been integrated in Beta 2.

Oh okay, thank you for clarify this.

[Sicro]

I have now integrated the changes and created a new pull request:
https://github.com/fantaisie-software/purebasic/pull/83

[Kurzer]

Wow, that was fast.
Thank you very much for your contribution, Sicro.

By the way: Do you know if the proposal on GitHub to make the PureBasic IDE independent from the necessary C compilations is already being worked on?
I haven't followed it up.

Stay well!
Kurzer

[Sicro]

By the way: Do you know if the proposal on GitHub to make the PureBasic IDE independent from the necessary C compilations is already being worked on?
I haven't followed it up.

The work is in progress. More off-topic via PN, please.

[Fred]

Already fixed in current release