Move back one directory

[Piero]

I wouldn't use GetCurrentDirectory() and/or SetCurrentDirectory() because that changes how your app runs, and you may just want to get a parent folder without changing the current directory used by your app.

My proc restores current dir by default (but you can also set it)
It can be useful to get the .app dir, at least on Mac (I just edited it to show how)

[Kiffi]

It can be useful to get the .app dir

No, it doesn't.

GetCurrentDirectory() returns the path from which your programme was called.

Code: Select all

MessageRequester("", GetCurrentDirectory())

When I run the programm from "C:\Code\PureBasic\":


When I run the programm from "C:\Code\":

[Piero]

It can be useful to get the .app dir

No, it doesn't.

I think that the path to the .exe directory (cannot test on windows atm) must be something simpler, like:

Code: Select all

GetPathPart(ProgramFilename())

The above also works for mac console programs (NOT .app packages) so should work for linux/win progs too

In case, try changing the level parameter of my procedure

[BarryG]

GetCurrentDirectory() returns the path of the calling process, for example if started from a batch file or another process. See below for proof. You can't 100% rely on it to return the exe's actual folder - you need ProgramFilename() for that.

Code: Select all

MessageRequester("", GetCurrentDirectory()) ; NEVER do this to get your exe's folder!

[DarkDragon]

GetCurrentDirectory() returns the path from which your programme was called

No, it actually returns the path of the calling process, for example if started from a batch file or another process. See below for proof. You can't 100% rely on it to return the exe's actual folder - you need ProgramFilename() for that.

Code: Select all

MessageRequester("", GetCurrentDirectory()) ; NEVER do this to get your exe's folder!

Just as Kiffi said and showed .

[BarryG]

Yeah, just edited my post when I realised, but you replied while I was editing. That's what I get for making speech balloons in my image.

[BarryG]

@Piero: Your code fails on Windows PCs for the same reason I showed in my screenshot above (it outputs C: instead of the correct D:). I know you said your code works on Mac, but it's definitely NOT cross-platform code (if anyone is hoping it is).

[Piero]

@Piero: Your code fails on Windows PCs for the same reason I showed in my screenshot above (it outputs C: instead of the correct D:). I know you said your code works on Mac, but it's definitely NOT cross-platform code (if anyone is hoping it is).

Just tested on windows 10 and it works!
Procedure UpperDir(path$, level = 1, setcurrdir.b = #False) posted above

viewtopic.php?p=631136#p631136 GetCurrentDirectory() is used as parameter of UpperDir(), but could be any path

viewtopic.php?p=631141#p631141 GetPathPart(ProgramFilename())

[BarryG]

Just tested on windows 10 and it works!

No, it doesn't. You didn't test it like how I said. Here's your code that I used, and the result below. You can clearly see the MessageRequester is NOT showing "D:" as the upper folder - it's showing "C:" by mistake.

Code: Select all

Procedure.s UpperDir(path$, level = 1, setcurrdir.b = #False)
   Protected i, oldcurrdir$ = GetCurrentDirectory()
   path$ = GetPathPart(path$) ; in case of file
   For i = 1 To level : path$ + ".." + #PS$ : Next
   SetCurrentDirectory(path$)
   path$ = GetCurrentDirectory()
   If Not setcurrdir : SetCurrentDirectory(oldcurrdir$) : EndIf
   ProcedureReturn path$
EndProcedure

MessageRequester("",UpperDir(GetCurrentDirectory()))

[Piero]

Just tested on windows 10 and it works!

No, it doesn't.

GetCurrentDirectory() is used as parameter of UpperDir(), but could be any path (I just added above)

[BarryG]

Okay, but in your original code you used this example, which is what I was saying was incorrect because it's unreliable (per my screenshot above):

Code: Select all

Debug UpperDir(GetCurrentDirectory())

Your code works fine if you DON'T use GetCurrentDirectory() as a parameter.

[Piero]

Okay

Yep; the problem was the path returned by GetCurrentDirectory in some non-standard situations, NOT my UpperDir procedure
I was about to sue you for harassment

Anyway, UpperDir also uses Get/SetCurrentDirectory internally; that makes the ".." magic happen

Code: Select all

Procedure.s UpperDir(path$, level = 1, setcurrdir.b = #False)
   Protected i, oldcurrdir$ = GetCurrentDirectory()
   path$ = GetPathPart(path$) ; in case of file
   For i = 1 To level : path$ + ".." + #PS$ : Next
   SetCurrentDirectory(path$)
   path$ = GetCurrentDirectory()
   If Not setcurrdir : SetCurrentDirectory(oldcurrdir$) : EndIf
   ProcedureReturn path$
EndProcedure

Debug GetCurrentDirectory()
Debug UpperDir(GetCurrentDirectory()) ; Does NOT change Current Directory
Debug GetCurrentDirectory()
Debug UpperDir(GetCurrentDirectory(), 2, 1) ; Goes up 2 "levels" and Changes Current Directory (1 = true)
Debug GetCurrentDirectory()
; Example usage: get .app folder (Mac)
Debug ".app folder on Mac: " + UpperDir(ProgramFilename(), 3)

; For Windows, Linux and Mac-console programs, you can use:
; GetPathPart(ProgramFilename())

[BarryG]

I was about to sue you for harassment

Haha, all good.