Issue with BOM

[kinglestat]

I had this code which worked on the 5.71 PB and now it doesn't with 6.1
has the BOM logic changed ?

Code: Select all

f = ReadFile( #PB_Any, filename, #PB_File_NoBuffering )

         If Not f
            filename = ""
            MessageRequester("LJLAng", "Could not read file")
         Else
            SetWindowTitle( #MainWindow, "Compiler - " + filename )
            
            format   = ReadStringFormat( f )             ;  Thanks to Infratec and Mesa
            LJLang::ValidTextFormat(format)
            
            body = ReadString(f,format | #PB_File_IgnoreEOL,#PB_File_IgnoreEOL)

[Cyllceaux]

This line is wrong

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL,#PB_File_IgnoreEOL)

The last Parameter is a number

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL, Lof(f))

[infratec]

In general you don't need this optional length parameter.
Only if you want to read an exact number of bytes.

[HeX0R]

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL, Lof(f))

I prefer

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL, Lof(f))

[boddhi]

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL, Lof(f))

I hadn't dared!
But hey, let's be crazy, why not:

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL, Lof(f))

[AZJIO]

Code: Select all

Debug #PB_File_IgnoreEOL ; 65536

using the third parameter, the author of the topic limits the number of bytes read (65536). This may be the reason that a larger file will be truncated. The third parameter is not intended to use the constant #PB_File_IgnoreEOL , it looks absurd, an error.

[Cyllceaux]

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL, Lof(f))

I hadn't dared!
But hey, let's be crazy, why not:

Code: Select all

body = ReadString(f,format | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL | #PB_File_IgnoreEOL, Lof(f))

To be honest... I only saw the last Parameter and the constant... I didn't check it

[kinglestat]

Thanks guys I will try it out

[boddhi]

To be honest... I only saw the last Parameter and the constant... I didn't check it

It happens to everyone. Sometimes between precipitation and forgetting to modify elements in the message... We have the choice!

It was just an opportunity to laugh a little... without thinking badly about it.