ScintillaSendMessage() -> ScintillaMessage()

[USCode]

Now that we have CocoaMessage(), would it be more consistent to rename ScintillaSendMessage() to just ScintillaMessage()?
Really a minor point and Fred is very good at command naming consistency, but it seems like this would be more consistent ... and slightly less typing too ...

[Fred]

That's a good point, changed.

[User_Russian]

Now that we have CocoaMessage(), would it be more consistent to rename ScintillaSendMessage() to just ScintillaMessage()?

In Windows there is, SendMessage_(), and the appointment of a lot like ScintillaSendMessage().
If we follow your logic, I am against renaming. After all PB under Windows use much more often than for MacOS X.

And imagine how much you will have to modify the code, and for compatibility with previous versions, you will need to use conditional compilation!

Code: Select all

CompilerIf #PB_Compiler_Version <520
  ScintillaSendMessage(....)
CompilerElse
  ScintillaMessage(....)
CompilerEndIf

And all for what? Because CocoaMessage in MacOS X? Delirium!
It's not worth it! This extra problems with a modification of code.

[Fred]

After some thought, I think it doesn't worth it as well even if this command isn't correctly name (it should have been SendScintillaMessage()). Anyway, not a big deal here.

[ts-soft]

Add both and mark the oldone as outdated
The oldone only as macro.

[USCode]

How about changing CocoaMessage() to CocoaSendMessage() then?
The command would only affect the less-used Mac version of OS X and it's only been with us since 5.10.