[4.61] ValF() sloooooooower than in 4.51 on Wine

[Niffo]

The code below takes about 10 seconds to execute on PB 4.61 on my machine and about 10 miliseconds on PB 4.51 !
ValF() is about 1000 times slower than in PB 4.51

Code: Select all

t = ElapsedMilliseconds()
For i = 1 To 10000
   a = ValF("1.5")
Next i
Debug ElapsedMilliseconds() - t

[gekkonier]

debug on/off?

[ts-soft]

The speed of the debugger is useless!

Code: Select all

t = ElapsedMilliseconds()
For i = 1 To 10000
   a = ValF("1.5")
Next i
MessageRequester("", Str(ElapsedMilliseconds() - t))

No difference!

Greetings - Thomas

[MachineCode]

The code below takes about 10 seconds to execute on PB 4.61 on my machine

Only takes 15 ms on my old XP PC with 4.61 installed. Try a fresh install of PureBasic 4.61 in a new folder and test again.

[Fred]

No problem here

[Niffo]

Hum ... ok ... i used to use PB on Wine (on Linux) and this difference seems to only exist on Wine and not on a real Windows
This is a real problem for me because one of my big project massively use ValF() and i want to continue to Use PB on Wine.
I suppose it can not be considered as a bug since it is not visible on a real Windows.
But there must be a difference in the code of the ValF() fonction between PB4.51 and PB4.61 that cause Wine to react differently.

[Fred]

We now always set the locale:

Code: Select all

  #ifdef WINDOWS
    setlocale(LC_NUMERIC, "English"); 
  #endif

because of this bug: http://www.purebasic.fr/english/viewtop ... 4&start=30

Wine has probably a slow way to do it, but that's mainly a Wine problem. I will try to see if getting the locale, compare it and only change it if necessary is faster.

[Niffo]

Thank you 1000 times !

[blueznl]

We now always set the locale:

Code: Select all

  #ifdef WINDOWS
    setlocale(LC_NUMERIC, "English"); 
  #endif

because of this bug: http://www.purebasic.fr/english/viewtop ... 4&start=30

Wine has probably a slow way to do it, but that's mainly a Wine problem. I will try to see if getting the locale, compare it and only change it if necessary is faster.

You are not authorised to read this forum.

Don't refer to something if people can't read it

[PMV]

It was readable when he wrote that.
After releases fixed bugs are always moved.

[c4s]

It was a bug I reported. Under certain circumstances ValF() did not detect "2.3" as a float anymore. The problem was that when opening e.g. OpenFileRequester() other system applications (namely an anti-virus tool but possibly others as well) changed the local setting again - That's probably what PureBasic did as well when our application started.
Anyway, after opening the file requester only "2,3" was detected...

[Niffo]

For information, there is the same "problem" with PB 5.00