need help asm to pb

sazuker · Post by **sazuker** » Fri Jun 06, 2008 7:42 am

Anyone could help me my pb translation is not working right
Your help would be much appreciated

org asm code

ProcInstallHook proc uses ebx edi esi hookProc:DWORD, targetProc:DWORD, patchLen:DWORD
	mov esi, patchLen
	mov edi, targetProc
	mov eax, esi
	add eax, 5
	invoke Alloc, eax
	mov ebx, eax
	invoke MemCopy, edi, eax, esi
	invoke VirtualProtect, edi, 5, PAGE_EXECUTE_READWRITE, ADDR targetProc
	mov eax, hookProc
	sub eax, edi
	sub eax, 5
	mov BYTE PTR [edi], 0E9h
	mov [edi + 1], eax
	invoke VirtualProtect, edi, 5, targetProc, ADDR targetProc
	sub edi, ebx
	add esi, ebx
	sub edi, 5
	mov BYTE PTR [esi], 0E9h
	mov [esi + 1], edi
	return ebx
ProcInstallHook endp

my PBcode

Code: Select all

Procedure ProcInstallHook(hookProc.l, targetProc.l, patchLen.l)
  myESI.l = patchLen
  myEDI.l = targetProc
  myEAX = myESI
  myEAX+5
  myEBX.l = AllocateMemory(myEAX)
  CopyMemory(@myEDI, @myEAX, myESI)
  VirtualProtect_(@myEDI, 5, PAGE_EXECUTE_READWRITE, @targetProc)
  myEAX = hookProc
  myEAX-myEDI
  myEAX-5
  PokeB(@myEDI, $E9)
  PokeL(@myEDI + 1, eax)
  VirtualProtect_(@myEDI, 5, targetProc, @targetProc)
  myEDI-myEBX
  myESI+myEBX
  myEDI-5
  PokeB(@myESI, $E9)
  PokeL(@myESI + 1, edi)
  ProcedureReturn myEBX
EndProcedure

Thanks!!!

Helle · Post by **Helle** » Fri Jun 06, 2008 8:21 am

PAGE_EXECUTE_READWRITE is a constant, take

Code: Select all

#PAGE_EXECUTE_READWRITE

Gruss
Helle

sazuker · Post by **sazuker** » Fri Jun 06, 2008 11:05 am

still doesnt werk

pointers and addresses are killing me
anyone could help me pls

Helle · Post by **Helle** » Fri Jun 06, 2008 11:42 am

Code: Select all

Procedure ProcInstallHook(hookProc.l, targetProc.l, patchLen.l) 
  ;Global targetProc.l
  Global myEAX.l
  Global myEBX.l
  Global myEDI.l = targetProc
  Global myESI.l = patchLen 
     
  myEAX = myESI 
  myEAX+5 
  myEBX.l = AllocateMemory(myEAX) 
  CopyMemory(@myEDI, @myEAX, myESI) 
  VirtualProtect_(myEDI, 5, #PAGE_EXECUTE_READWRITE, @targetProc) 
  myEAX = hookProc 
  myEAX-myEDI 
  myEAX-5 
  PokeB(@myEDI, $E9) 
  PokeL(@myEDI + 1, eax) 
  VirtualProtect_(myEDI, 5, targetProc, @targetProc) 
  myEDI-myEBX 
  myESI+myEBX 
  myEDI-5 
  PokeB(@myESI, $E9) 
  PokeL(@myESI + 1, edi) 
  ProcedureReturn myEBX 
EndProcedure

Gruß
Helle

P.S.: I use VirtualProtectEx()
Edit: The 1.Parameter of VirtualProtect is a value, not a pointer.
For a example (patching) with VirtualProtectEx see http://www.purebasic.fr/german/viewtopic.php?t=16780 (comments in german).

sazuker · Post by **sazuker** » Mon Jun 09, 2008 4:08 pm

thx for all the help Helle
its now running!!!!