Office-style menus

Flype · Post by **Flype** » Sun May 27, 2007 12:08 pm

that's really neat. thank you for this.

now, the good idea is to add icons support

eesau · Post by **eesau** » Mon May 28, 2007 10:16 am

Updated the code in my first post (also put it between a single code-block for easier copy-pasting).

Added: Icon support! Add icons to menu items with:

Code: Select all

OfficeMenuSetIcon ( MenuID , ItemID , IconID )

Only native icons for now, will add support later for other image types. (See the "Tools"-menu for an example on how they look).

Added: Check marks. See "File"-menu for example.

Still to do:

- There's some slight flickering, I'll hopefully get rid of that by using memdc's.
- Fix code for Win98. Hard to do, since I don't have Win98 available right now, but I'll try anyway. The problems with the code and W98 is that previous Windows-versions had globally shared menu resources, which were very particular about what you did to them. W2K is probably the same. I'll see if I can find a fix though.
- Better icon support, different image formats and so on. Also, disabled icon states.
- Fix edit control (string gadget) context menus.
- Better coloring and color management.
- Slap the whole thing on a rebar, so we can get a menu identical to the ones in MS Office -products.

That's it for now, let me know if you find more bugs.

Derek · Post by **Derek** » Mon May 28, 2007 10:45 am

This is getting better and better. Like the icons.

Doesn't seem to flicker on my system.

DoubleDutch · Post by **DoubleDutch** » Mon May 28, 2007 12:06 pm

On Vista the chr(9) stuff to put the keyboard shortcut on the right (right justified) just seems to do a regular tab. Haven't looked on anything other than Vista, maybe the same on others?

electrochrisso · Post by **electrochrisso** » Mon May 28, 2007 12:57 pm

Great Work
Works great on my clunky old laptop under 98se but I get odd character next to some menu items, probably where the icons should go?. otherwise it works smoothly.

eesau · Post by **eesau** » Mon May 28, 2007 2:26 pm

electrochrisso wrote:Great Work
Works great on my clunky old laptop under 98se but I get odd character next to some menu items, probably where the icons should go?. otherwise it works smoothly.

What menu items exactly? Do you see any icons or checkmarks at all?

eesau · Post by **eesau** » Mon May 28, 2007 2:28 pm

Updated the code to include yet another hack to work around the system menu, hopefully the last one needed.

Tranquil · Post by **Tranquil** » Tue May 29, 2007 10:43 am

The Code seems not to Work on Windows 2000 (completely patched). I have a normal menu here without any Icon and some ASCII Codes in there....

ABBKlaus · Post by **ABBKlaus** » Tue May 29, 2007 11:23 am

@Tranquil
change this line to If OSVersion ( ) => #PB_OS_Windows_98

Code: Select all

Procedure InitOffice ( Window ) 
    
   If OSVersion ( ) => #PB_OS_Windows_98 ; #PB_OS_Windows_XP 
    
      If Not GetProp_ ( WindowID ( Window ) , "OfficeMenuHook" ) 
         
         SetProp_ ( WindowID ( Window ) , "WindowProc" , SetWindowLong_ ( WindowID ( Window ) , #GWL_WNDPROC , @OfficeWindowCallback ( ) ) ) 
    
         SetProp_ ( WindowID ( Window ) , "OfficeMenuHook" , SetWindowsHookEx_ ( #WH_CALLWNDPROC , @OfficeHook ( ) , #Null , GetWindowThreadProcessId_ ( WindowID ( Window ) , #Null ) ) ) 
       
         ProcedureReturn #True 
       
      EndIf 

   EndIf 

   ProcedureReturn #Null 

EndProcedure

techjunkie · Post by **techjunkie** » Tue May 29, 2007 11:45 am

Extremely super cool!!

and very nice looking code! Great work!

eesau · Post by **eesau** » Tue May 29, 2007 12:46 pm

Added: Coloring that is system color-consistent and mimics Office about 99% accurately.

Derek · Post by **Derek** » Tue May 29, 2007 1:02 pm

Brilliant, will be using this in the programs I write for work. Thanks.

eesau · Post by **eesau** » Tue May 29, 2007 1:06 pm

Oh, almost forgot. A big thanks to everyone for the nice comments

ABBKlaus · Post by **ABBKlaus** » Tue May 29, 2007 6:20 pm

@eesau : again no run on Win98

Code: Select all

Procedure InitOffice ( Window ) 
    
   If OSVersion ( ) > #PB_OS_Windows_98 
    
      If Not GetProp_ ( WindowID ( Window ) , "OfficeMenuHook" ) 
         
         SetProp_ ( WindowID ( Window ) , "WindowProc" , SetWindowLong_ ( WindowID ( Window ) , #GWL_WNDPROC , @OfficeWindowCallback ( ) ) ) 
    
         SetProp_ ( WindowID ( Window ) , "OfficeMenuHook" , SetWindowsHookEx_ ( #WH_CALLWNDPROC , @OfficeHook ( ) , #Null , GetWindowThreadProcessId_ ( WindowID ( Window ) , #Null ) ) ) 
       
         ProcedureReturn #True 
       
      EndIf 

   EndIf 

   ProcedureReturn #Null 

EndProcedure

eesau · Post by **eesau** » Tue May 29, 2007 7:03 pm

ABBKlaus wrote:@eesau : again no run on Win98
Code: Select all
If OSVersion ( ) > #PB_OS_Windows_98

Forgot to remove that

It *should* run on Win98, but I'll have to test some more.