Your opinion on the new Droopy's Lib site?

[lexvictory]

I would like you to have a look at a new site that I designed in the past couple of days.
It is the Droopy's Lib site which I manage.
located at: http://new-droopy.coolinc.info/ (this will change when it replaces the main site)

if your browser is set to prefer French pages to English ones, you will most likely get the French version of the site.

could you please let me know what you think of the site?, and if you speak french and spot any obvious errors in google's translation, please tell me.

the news page has an explanation about the new site, as does the index page, but to a lesser extent

[srod]

I automatically get the French pages for some reason! There's nothing amiss with my computer's regional settings etc.

[Derek]

Yeah, I get the french as well.

[chromaX]

Same here.

In my opinion the light green and the blue kind of "bite" each other...
I would stick to just one color, namely blue.

[lexvictory]

well thats odd...
and it has nothing to do with ure regional settings, it has to do with ure browsers settings, and i dont know how to configure it in IE, but if you use Firefox or opera i can help u...
can u both please go to http://new-droopy.coolinc.info/showacceptlang.php and tell me what it says for u?

[srod]

It says 'en-gb'.

I use IE 6.

[chromaX]

Opera: de-CH,de;q=0.9,en;q=0.8

Settings are therefor:
1. de-CH
2. de
3. en

(Which variable contains this useful info?)

[lexvictory]

thats f*****g odd....because neither of u hav french comming as the first 2 characters...

this is the php code behind it:

Code: Select all

if (strpos($_SERVER['HTTP_ACCEPT_LANGUAGE'], "fr") == 0) { 
    $langdir = "fr";
  } else {
    $langdir = "en";
  }

i.e. its testing for if fr starts at the first character....
i think i know what it is; the strpos is evaluating to a bool false value, so the == thinks that it equals 0....
gimme a moment and i'll modify it so that it checks if its bool false first...

[lexvictory]

ok, can u all please try loading the main page again?

[Derek]

I get the same as Srod

En gb

I'm using ie7

[Derek]

It's in english now.

[srod]

Now it's in bloody German!




Looks good.

[lexvictory]

well, thats good....
me and php dont always mix correctly....
coz it treats bools differently to pb....

Now it's in bloody German!

now that i would love to see.....

[chromaX]

Don't check for bool, just do it with" ===". This checks also the type of the Variable without another function.

Code: Select all

if (strpos($_SERVER['HTTP_ACCEPT_LANGUAGE'], "fr") === FALSE) { 
    $langdir = "fr"; 
  } else { 
    $langdir = "en"; 
  }

Also, your code has a weak point. If someone has multiple preferences (like I do) you should check for the language which appears first, assuming that they are ordered after preference. Or (I don't know if the Syntax Opera uses is generally used, I'll be checking that) do it with an array, first splitting the string with regular expressions and then comparing the priority of $array['en'] and $array['fr'].

/EDIT: It is the same syntax, at least in FF.
/EDIT2: If it's just two languages, my second point can be ignored.

[lexvictory]

Don't check for bool, just do it with" ===". This checks also the type of the Variable without another function.

Code: Select all

if (strpos($_SERVER['HTTP_ACCEPT_LANGUAGE'], "fr") === 0) { 
    $langdir = "fr"; 
  } else { 
    $langdir = "en"; 
  }

Also, your code has a weak point. If someone has multiple preferences (like I do) you should check for the language which appears first, assuming that they are ordered after preference. Or (I don't know if the Syntax Opera uses is generally used, I'll be checking that) do it with an array, first splitting the string with regular expressions and then comparing the priority of $array['en'] and $array['fr'].

well, i have it fixed, but with a slightly different arrangement....
and since the site has only 2 languages, i simply check if french is the first priority, usually its the first option, and if french isnt the 1st one, it gives the english version....
wats the bet that i'll now get complaints that the french people are getting the english version....