Rename FinishDirectory() to FreeDirectory()

Tranquil · Post by **Tranquil** » Wed Nov 15, 2006 7:38 pm

Hi PB Team.

All commands uses FreeXXXXX Commands to free any PB allocated resources. Only ExamineDirectory uses FinishDirectory().

To be common with all other commands it maybe better to rename this to FreeDirectory() too?

Cheers
Mike

AND51 · Post by **AND51** » Wed Nov 15, 2006 7:55 pm

Why not use macros until Fred agrees you?

Code: Select all

Macro FreeDirectory(dir)
     FinishDirectory(dir)
Macro

Advantage: No performance-loss, because you use a macro insted of a procedure.

Hast du alles verstanden?

Trond · Post by **Trond** » Wed Nov 15, 2006 10:45 pm

All Examine*() functions are closed with Finish*()

ts-soft · Post by **ts-soft** » Wed Nov 15, 2006 11:52 pm

Trond wrote:All Examine*() functions are closed with Finish*()

No, only directory!
CloseDirectory or FreeDirectory is more logical in my head

Tranquil · Post by **Tranquil** » Thu Nov 16, 2006 6:03 am

ts-soft wrote:
Trond wrote:All Examine*() functions are closed with Finish*()
No, only directory!
CloseDirectory or FreeDirectory is more logical in my head

You are right, it sounds more logicaly.
This was the first time I used the FileSystem Lib of PB. And while coding I wanted to release the #PB_Any allocated Ressources and wondered that FreeDirectory() does not exist.

But anyway, I can also live with FinishDirectory().

AND51 · Post by **AND51** » Thu Nov 16, 2006 8:59 am

You sound, as if you didn't pay attention to my post...

Tranquil · Post by **Tranquil** » Thu Nov 16, 2006 9:24 am

AND51 wrote:You sound, as if you didn't pay attention to my post...

I noticed your message, sorry for not replaying to it.
The reason of my posting was only something logical I encountered while coding. Your Macro is surely a workarround for me, but its not really neccessary.

Anyway, thanks for your idea.

Und klaro hab ich Dich verstanden.

AND51 · Post by **AND51** » Thu Nov 16, 2006 9:32 am

lol, dann ist ja alles im Lot.

All in all, I also agree to Tranquils idea renaming FinishDirectory() to FreeDirectory().