PureBasic Forums - English

My app has a lot of repeated hard-coded literal strings of "Done" throughout (about 60). Does PureBasic create a new internal string for all these occurrences, or does it make one single reference to it and call that every time "Done" is used in my code? In other words, should I perhaps set Global done$="Done" instead and used done$ throughout my code? Is that a better for optimisation? Or maybe as a constant?

I haven't used a Global variable for it yet because that makes it harder to see in my code (due to not being highlighted as a literal string anymore, which is important for me).

For string literals and/or constants only 1x memory is allocated. Ask 'Kurzer' how his balls are. He can tell you more about this topic

BarryG wrote:My app has a lot of repeated hard-coded literal strings of "Done" throughout (about 60). Does PureBasic create a new internal string for all these occurrences, or does it make one single reference to it and call that every time "Done" is used in my code? In other words, should I perhaps set Global done$="Done" instead and used done$ throughout my code? Is that a better for optimisation? Or maybe as a constant? ...

This would be a choice based purely on performance and memory management.

Global variables are still variables, meaning that their values are mutable. The resources required to maintain references to global variables are locked throughout the life cycle of the program, as they must be accessible and modifiable from every stack, and only released upon program termination. Local variables, on the other hand, are instantiated and used only within the scope of the stack in which they are defined, and released once the stack is popped. Clearly more efficient, unless in cases of recursion.

Alternatively, for values that do not require mutation, constants might prove a better choice. Like global variables, constants are also locked throughout the life cycle of the program and accessible from anywhere in the program, but since they are non-mutable objects, they benefit from better compiler optimisations.

IMHO, for the requirement you've cited, it's never a good idea to redefine common values used throughout the program. So, constants would be the ideal implementation.

BarryG,

apart from the fact that using 60 hard coded "done"s in the source code is not a good programming style (you will notice this if you want to change something in the literal later and have to do it 60 times), the PB compiler converts this literal into a single string literal and refers to it at the 60 places.

As Josh has already pointed out, I learned this the hard way: viewtopic.php?p=550897#p550897

So, in your case, I would definitely use a constant for that.
#DONE_MSG = "Done"

Stay well!
Kurzer

I don't know how it's implemented in your case. But if possible, you should always use integer variables: