Page 1 of 1
ScintillaSendMessage() -> ScintillaMessage()
Posted: Fri Aug 30, 2013 10:10 pm
by USCode
Now that we have CocoaMessage(), would it be more consistent to rename ScintillaSendMessage() to just ScintillaMessage()?
Really a minor point and Fred is very good at command naming consistency, but it seems like this would be more consistent ... and slightly less typing too ...
Re: ScintillaSendMessage() -> ScintillaMessage()
Posted: Sat Aug 31, 2013 11:18 am
by Fred
That's a good point, changed.
Re: ScintillaSendMessage() -> ScintillaMessage()
Posted: Sat Aug 31, 2013 11:35 am
by User_Russian
USCode wrote:Now that we have CocoaMessage(), would it be more consistent to rename ScintillaSendMessage() to just ScintillaMessage()?
In Windows there is,
SendMessage_(), and the appointment of a lot like Scintilla
SendMessage().
If we follow your logic,
I am against renaming. After all PB under Windows use much more often than for MacOS X.
And imagine how much you will have to modify the code, and for compatibility with previous versions, you will need to use conditional compilation!
Code: Select all
CompilerIf #PB_Compiler_Version <520
ScintillaSendMessage(....)
CompilerElse
ScintillaMessage(....)
CompilerEndIf
And all for what? Because CocoaMessage in MacOS X? Delirium!
It's not worth it! This extra problems with a modification of code.
Re: ScintillaSendMessage() -> ScintillaMessage()
Posted: Sat Aug 31, 2013 11:40 am
by Fred
After some thought, I think it doesn't worth it as well even if this command isn't correctly name (it should have been SendScintillaMessage()). Anyway, not a big deal here.
Re: ScintillaSendMessage() -> ScintillaMessage()
Posted: Sat Aug 31, 2013 11:43 am
by ts-soft
Add both and mark the oldone as outdated
The oldone only as macro.
Re: ScintillaSendMessage() -> ScintillaMessage()
Posted: Sun Sep 01, 2013 8:37 pm
by USCode
How about changing CocoaMessage() to CocoaSendMessage() then?
The command would only affect the less-used Mac version of OS X and it's only been with us since 5.10.