Page 1 of 3

ComboBoxGadget(): Full row selection ?

Posted: Sat Apr 17, 2010 10:12 am
by c4s
The new combobox (since 4.50) doesn't look like the old one. I know it's for the support of icons but it just looks wrong if the whole row isn't selected and also between them is more space:
Image

So is it still possible to get back the old look when I don't need the icon functionality? Maybe with a flag like #PB_ComboBox_List or so?

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 11:17 am
by Seldon
I have not the 4.50 version, but I do hope this will be changed, maybe by adding a FLAG to have a full row selection.

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 11:21 am
by srod
Seems to be an XP thing. Works fine on my Vista setup.

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 2:37 pm
by netmaestro
Seems to be an XP thing. Works fine on my Vista setup.
Yes, same here on win7. If you wanted to work around it for xp I'm at a loss, as ownerdrawing seems unavailable on ComboBoxEx. Or am I wrong?

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 3:44 pm
by Trond
netmaestro wrote:
Seems to be an XP thing. Works fine on my Vista setup.
Yes, same here on win7. If you wanted to work around it for xp I'm at a loss, as ownerdrawing seems unavailable on ComboBoxEx. Or am I wrong?
They could just change it back to a normal combobox.

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 5:54 pm
by c4s
I didn't know it has something to do with XP. Anyway the rows still use more space on Vista and 7?

My intention was - if there isn't any (easy) Api solution - to get an option for using the normal combobox instead of comboboxex if we don't need it.

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 6:02 pm
by netmaestro
It would be a matter of using CreateWindowEx_() and managing the whole thing through API. If you're really serious about it you could make one and use PBOSL's RealGadget library to bring it more or less native. If it was me I'd just learn to love the shorter selection bars. You could also make a feature request, something like #PB_Combobox_NoImages where the old one would be used instead of the new one.

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 6:06 pm
by Arctic Fox

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 7:47 pm
by c4s
Arctic Fox wrote:Take a look at srod's wrapper
http://www.purebasic.fr/english/viewtop ... 12&t=41683
Thanks, but I'm not that serious about it. It's more an aesthetic thing.
netmaestro wrote:You could also make a feature request, something like #PB_Combobox_NoImages where the old one would be used instead of the new one.
Yes I'll do this. I thought Freak or Fred will say something like "oh we overlooked this. A flag is coming in Beta 3.".
Well now they get my feature request. :)

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 8:06 pm
by freak
The ExplorerComboGadget() has been like this since the beginning and nobody seemed to care. I don't see the big deal with this.

Re: ComboBoxGadget(): Full row selection ?

Posted: Sun Apr 18, 2010 9:13 pm
by c4s
Out of my user experience I have to say that I'm familiar with having it on these explorerlists but not at comboboxes. In fact I think I've never seen such a combobox before that's why I'm so confused.

Re: ComboBoxGadget(): Full row selection ?

Posted: Mon Apr 19, 2010 12:05 pm
by Seldon
A 'COMBOBOX' gadget should not act like that because it is not comfortable for the user and since under Vista and 7 works OK, it means there's something wrong like a bug or something missing in the code. BTW is this command still opening a COMBOBOX class window ? Or is it a custom class ?

Re: ComboBoxGadget(): Full row selection ?

Posted: Mon Apr 19, 2010 12:28 pm
by srod
It is a ComboBoxEx (which is a Windows common control) and the bug really must be with XP's common controls lib.

Re: ComboBoxGadget(): Full row selection ?

Posted: Mon Apr 19, 2010 4:21 pm
by Seldon
Maybe it is not a bug, but since ComboboxEx class controls are basically Combobox controls that provide support for item images, why not adding them instead of replacing ? I mean we could have two functions: ComboboxGadget() and ComboboxExGadget() . Or maybe PB internally could switch to basic Combobox class control when no item image is used.

Re: ComboBoxGadget(): Full row selection ?

Posted: Mon Apr 19, 2010 4:30 pm
by c4s
@Seldon
I think a flag would be the easiest solution. Here I already made a feature request for this: http://www.purebasic.fr/english/viewtop ... =3&t=41921