Demivec wrote:
@Michael Vogel:
[1] I couldn't test your new sample because I didn't have the VFNCopy procedure.
[2] Since you really want GetNumber your way (instead of the easy way
) use this:
Code: Select all
Procedure GetNumber(*s.String,*num.VNF)
Protected n
Protected T.s
If *num\sign
T="-"
EndIf
n=*num\len
T+Str(*num\num[n])
While n>0
n-1
T+RSet(Str(*num\num[n]),#VNFLen,"0")
Wend
*s\s=T; Does work!!!!
EndProcedure
zahl3.String ;use a structure for a string
GetNumber(@zahl3,@num1)
Debug zahl3\s
...you don't need to use @...
Hi Demivec,
thanks for your reply, for
[1] you'll can see the actual code below - I think it's about 5 to 10 times faster than all other routines - I would be happy of course if someone will be able to tune it a little bit
I've also include a
Add and
Sub procedure now (not very well tested for now), so next step would be
Div...
Hopefully, all routines work with positive and negative integers.
[2] - I can't get it running, I entered all changes (.String and \s) but there's still an error when running (Null pointer), I'm using PB4.02 Win -- you're right, Number() is doing the same, but there are things I just want to know how it can be done
[3] - Thanks again, looks better when reading the source...
And here's the "full" code (sorry for the long postings, mikes idea with a wiki is a clever thing) - now the benchmark from the last post will run...
Code: Select all
; Define VNF - Vogels Number Format
#VNFDim=10000; ~90000 Ciphers ;)
#VNFLen=9
#VNFMod=1000000000
#VNFNegative=-1
#VNFPositive=0
Structure VNF
len.w
sign.w
num.l[#VNFDim]
EndStructure
Declare.s Number(*num.VNF); String
Declare GetNumber(*s.s,*num.VNF); s <- num
Declare PutNumber(*s.s,*num.VNF); s -> num
Declare VNFNormalize(*a.VNF); a = (a)
Declare VNFCopy(*a.VNF,*b.VNF); b = a
Declare VNFMul(*a.VNF,*b.VNF,*c.VNF); c = a*b
Declare VNFAdd(*a.VNF,*b.VNF,*c.VNF); c = a+b
Declare VNFSub(*a.VNF,*b.VNF,*c.VNF); c = a-b
Declare.l VNFGt(*a.VNF,*b.VNF); true, if a>b
Declare.l VNFEq(*a.VNF,*b.VNF); true, if a=b
; EndDefine
Procedure.s Number(*num.VNF)
Protected n
Protected t.s
If *num\sign
t="-"
EndIf
n=*num\len
t+Str(*num\num[n])
While n>0
n-1
t+RSet(Str(*num\num[n]),#VNFLen,"0")
Wend
ProcedureReturn t
EndProcedure
Procedure GetNumber(*s.String,*num.VNF)
; ACHTUNG! s ist bei dieser Routine vom Typ String!
; (bei x.string bedeutet dies den Aufruf "GetNumber(x,number)" und die Ausgabe "Debug x\s")
Protected n
Protected t.s
If *num\sign
t="-"
EndIf
n=*num\len
t+Str(*num\num[n])
While n>0
n-1
t+RSet(Str(*num\num[n]),#VNFLen,"0")
Wend
*s\s=t
EndProcedure
Procedure PutNumber(*s.s,*num.VNF)
Protected n,p
Protected t.s
*num\sign=0
t=PeekS(@*s)
n=Len(t)-#VNFLen
While n>0
*num\num[p]=Val(PeekS(@t+n,#VNFLen))
p+1
n-#VNFLen
Wend
n=Val(PeekS(@t,9+n))
If n<0
*num\sign=#VNFNegative
n=-n
EndIf
*num\num[p]=n
*num\len=p
EndProcedure
Procedure VNFNormalize(*a.VNF)
; Strap leading zeros (000.000.000)
While (*a\len>=0) And (*a\num[*a\len]=0)
*a\len-1
Wend
; Value equal Zero? Positiv sign
If *a\len<0
*a\len=0
*a\sign=#VNFPositive
EndIf
EndProcedure
Procedure VNFCopy(*a.VNF,*b.VNF)
Protected n=*a\len
*b\len=n
*b\sign=*a\sign
Repeat
*b\num[n]=*a\num[n]
n-1
Until n<0
EndProcedure
Procedure.l VNFEq(*a.VNF,*b.VNF)
Protected n,d
If n<>*b\len
ProcedureReturn #False
ElseIf *a\sign<>*b\sign
ProcedureReturn #False
Else
While n>=0
If *a\num[n]<>*b\num[n]
ProcedureReturn #False
EndIf
n-1
Wend
ProcedureReturn #True; a=b
EndIf
EndProcedure
Procedure.l VNFGt(*a.VNF,*b.VNF)
Protected n,d
If *a\sign<>*b\sign
If *a\sign=#VNFPositive
ProcedureReturn #True
Else
ProcedureReturn #False
EndIf
Else
n=*a\len
If n>*b\len
ProcedureReturn #True
ElseIf n<*b\len
ProcedureReturn #False
Else
While n>=0
d=*a\num[n]-*b\num[n]
If d>0
ProcedureReturn #True
ElseIf d<0
ProcedureReturn #False
EndIf
n-1
Wend
ProcedureReturn #False; a=b
EndIf
EndIf
EndProcedure
Procedure VNFMul(*a.VNF,*b.VNF,*c.VNF)
Protected la
Protected lb
Protected n
Protected s.q
Protected z.q
*c\sign=-(*a\sign * *b\sign)
*c\len=*a\len+*b\len+1
For n=0 To *c\len
*c\num[n]=0
Next n
la=0
Repeat
lb=0
z=*b\num[lb]
Repeat
s=*a\num[la] * *b\num[lb] + *c\num[la+lb]
;Debug Str(*a\num[la])+" * "+Str(*b\num[lb])+" + "+Str(*c\num[la+lb+1])
;Debug " = "+StrQ(s)+" -> "+Str(s/#VNFMod)+" | "+Str(s%#VNFMod)
*c\num[la+lb]=s%#VNFMod
*c\num[la+lb+1]+s/#VNFMod
lb+1
Until lb>*b\len
la+1
Until la>*a\len
VNFNormalize(*c)
EndProcedure
Procedure VNFAdd(*a.VNF,*b.VNF,*c.VNF)
Protected n
Protected s
If *a\sign<>*b\sign
;Debug "sub"
*b\sign=*a\sign
VNFSub(*a.VNF,*b.VNF,*c.VNF)
Else
*c\sign=*a\sign
If *a\len<*b\len
Swap *a,*b
EndIf
While n<=*a\len
s+*a\num[n]
If n<=*b\len
s+*b\num[n]
EndIf
*c\num[n]=s%#VNFMod
s/#VNFMod
n+1
Wend
If s
*c\num[n]=s
Else
n-1
EndIf
*c\len=n
EndIf
EndProcedure
Procedure VNFSub(*a.VNF,*b.VNF,*c.VNF)
Protected n
Protected s
If *a\sign<>*b\sign
;Debug "add"
*b\sign=*a\sign
VNFAdd(*a.VNF,*b.VNF,*c.VNF)
Else
If VNFGt(*a.VNF,*b.VNF)
*c\sign=*a\sign
Else
;Debug "swp"
Swap *a,*b
*c\sign=#VNFNegative-*a\sign
EndIf
While n<=*a\len
s+*a\num[n]
If n<=*b\len
s-*b\num[n]
EndIf
If s<0
*c\num[n]=s+#VNFMod
s=-1
Else
*c\num[n]=s
s=0
EndIf
n+1
Wend
*c\len=n-1
VNFNormalize(*c)
EndIf
EndProcedure
num1.VNF
num2.VNF
num3.VNF
;zahl1.s="123456789098765432198765432123456789"
zahl1.s="5555555556666666666777777777777777778765434567654"
zahl2.s="-5555555556666666666777777777777777778765434567653"
PutNumber(@zahl1,num1)
PutNumber(@zahl2,num2)
VNFAdd(num1,num2,num3)
Debug Number(num3)
Updated code - 22. July 2007
Take the ".s" off the *s.s in the procedure. Sorry!
.