ProGUI V1.38 UI Library (Small Bug Fix)

[PrincieD]

Thank you

You're welcome

[Poshu]

Mmmh, I have some redraw problem when a rebar width grows up; is there a way to add a callback that would allow me to resize and move my gadgets before the rebar is redrawn?

[PrincieD]

Mmmh, I have some redraw problem when a rebar width grows up; is there a way to add a callback that would allow me to resize and move my gadgets before the rebar is redrawn?

Hey Poshu,

Do you mean when the rebar's height changes due to the width? ProGUI sends a #REBAR_UPDATED message to the parent window's message queue when the layout changes. The following code snippet from the office example demonstrates how to resize gadgets when the rebar's layout changes: -

Code: Select all

Event = WaitWindowEvent()
  window = EventWindow()
  
  ; resize scintilla gadget when rebar updated msg received
  If Event = #REBAR_UPDATED
    ResizeGadget(editor, 0, EventwParam(), WindowWidth(#Window_0), WindowHeight(#Window_0)-EventwParam())
  EndIf

Chris.

[Poshu]

Oups, as always my english is confused, I meant height change, yeah.

With this example (which was what I was doing) my rebar is drawn before I can resize my gadgets, resulting some nice bugs. I wanted to resize my gadgets before any redraw of my rebar.
Achieved with a callback, thanks anyway.

[PrincieD]

Oups, as always my english is confused, I meant height change, yeah.

With this example (which was what I was doing) my rebar is drawn before I can resize my gadgets, resulting some nice bugs. I wanted to resize my gadgets before any redraw of my rebar.
Achieved with a callback, thanks anyway.

Ahh I see the problem now, the message gets posted after the rebar has already occupied the new space (overlapping existing gadgets for a brief moment). I'll make so the #REBAR_UPDATED message gets posted before the rebar redraws in the new release, that way theres no need for an extra callback. The new release is going good by the way new skin subsystem and API complete, new ButtonEx complete, just fixing reported bugs now then save/load rebar layout left to implement and docs/examples to update. If I can squeeze it into this release there will also be a little visual skin editor tool included too

Chris.

[Poshu]

the message gets posted after the rebar has already occupied the new space (overlapping existing gadgets for a brief moment)

Yep, that's exactly my point (damn, you're good when it comes to understand crappy english °_°; ) I do prefer callback for event handling anyway... Well, strange thing actually, I believe the high order word of lparam should contain the new height, but I just peek some strange numbers, what am I doing wrong?

Edit: damn myself, I was peeka instead of peekw, nevermind.

[PrincieD]

the message gets posted after the rebar has already occupied the new space (overlapping existing gadgets for a brief moment)

Yep, that's exactly my point (damn, you're good when it comes to understand crappy english °_°; ) I do prefer callback for event handling anyway... Well, strange thing actually, I believe the low high order word of lparam should contain the new height, but I just peek some strange numbers, what am I doing wrong?

Edit: damn myself, I was peeka instead of peekw, nevermind.

hehe your English isn't that crappy I'll add a command to set a separate user-callback too if you prefer that method then

Chris.

[PrincieD]

fixed all the reported bugs now, wow! for once, i might actually make the estimated release date of sunday lol

[Marco2007]

Cool

[Poshu]

fixed all the reported bugs now, wow! for once, i might actually make the estimated release date of sunday lol

Sweet!

...

Then I think it's time for me to post my little planning-fucking wish list, right?

1. •For an easier use of ProGUI, you should make the command list a bit more uniform, like why GetToolBarExHeight while RebarHeight? PureBasic convention seems to tell users that there is no "get" when we are looking for a size: WindowHeight, ImageHeight, GadgetHeight... (I know it's not really important, I just think that it would feel more natural)

1. •Memory leaks: yeah, there is memory leaks almost everywhere, and it REALLY need to be fixed, here is an easy demonstration:

Code: Select all

StartProGUI("",0,0,0,0,0,0,0)

OpenWindow(0,10,10,300,300,"Prululu",#PB_Window_SystemMenu)
ButtonGadget(1,150,150,50,20,"Nya")
CreateToolBarEx(2,WindowID(0),16,16, #TBSTYLE_HIDECLIPPEDBUTTONS)
ToolBarButtonEx(3, "Nyoron!", #BTNS_BUTTON)
ToolBarButtonEx(4, "Mugyu ?", #BTNS_BUTTON)
ToolBarButtonEx(5, "Gema...", #BTNS_BUTTON)


Repeat
  Select WaitWindowEvent()
    Case #PB_Event_Gadget
      FreeToolBarEx(2)
      CreateToolBarEx(2,WindowID(0),16,16, #TBSTYLE_HIDECLIPPEDBUTTONS)
      ToolBarButtonEx(3, "Nyoron!", #BTNS_BUTTON)
      ToolBarButtonEx(4, "Mugyu ?", #BTNS_BUTTON)
      ToolBarButtonEx(5, "Gema...", #BTNS_BUTTON)
    Case #PB_Event_CloseWindow
      End
  EndSelect
ForEver

1. Just press the self-explanatory "nya" button and enjoy your ram consumption growing up!

1. •It would be nice to be able to get a rebarband ID after it's creation (something like RebarBandID(RebarID.i,GadgetID.i)?)

1. •More to come, I swear.

I'll add a command to set a separate user-callback too if you prefer that method then

I don't see this as an usefull feature. It might confuse users that are not familiar with callback and it's quite easy to subclass your gadget anyway.

[PrincieD]

Sweet!

...

Then I think it's time for me to post my little planning-fucking wish list, right?

1. •For an easier use of ProGUI, you should make the command list a bit more uniform, like why GetToolBarExHeight while RebarHeight? PureBasic convention seems to tell users that there is no "get" when we are looking for a size: WindowHeight, ImageHeight, GadgetHeight... (I know it's not really important, I just think that it would feel more natural)

1. •Memory leaks: yeah, there is memory leaks almost everywhere, and it REALLY need to be fixed, here is an easy demonstration:

Code: Select all

StartProGUI("",0,0,0,0,0,0,0)

OpenWindow(0,10,10,300,300,"Prululu",#PB_Window_SystemMenu)
ButtonGadget(1,150,150,50,20,"Nya")
CreateToolBarEx(2,WindowID(0),16,16, #TBSTYLE_HIDECLIPPEDBUTTONS)
ToolBarButtonEx(3, "Nyoron!", #BTNS_BUTTON)
ToolBarButtonEx(4, "Mugyu ?", #BTNS_BUTTON)
ToolBarButtonEx(5, "Gema...", #BTNS_BUTTON)


Repeat
  Select WaitWindowEvent()
    Case #PB_Event_Gadget
      FreeToolBarEx(2)
      CreateToolBarEx(2,WindowID(0),16,16, #TBSTYLE_HIDECLIPPEDBUTTONS)
      ToolBarButtonEx(3, "Nyoron!", #BTNS_BUTTON)
      ToolBarButtonEx(4, "Mugyu ?", #BTNS_BUTTON)
      ToolBarButtonEx(5, "Gema...", #BTNS_BUTTON)
    Case #PB_Event_CloseWindow
      End
  EndSelect
ForEver

1. Just press the self-explanatory "nya" button and enjoy your ram consumption growing up!

1. •It would be nice to be able to get a rebarband ID after it's creation (something like RebarBandID(RebarID.i,GadgetID.i)?)

1. •More to come, I swear.

I'll add a command to set a separate user-callback too if you prefer that method then

I don't see this as an usefull feature. It might confuse users that are not familiar with callback and it's quite easy to subclass your gadget anyway.

Thanks Poshu! I'll get onto it and I really do appreciate you reporting theses issues, it can be tricky accounting for all possible scenarios sometimes and it helps a lot when you let me know what needs fixing or improving. Keep em coming! The new update probably won't be ready just yet today but it's about 90% complete - probably late tonight maybe or sometime tomorrow (I have to update the docs and examples too, which will take a while - a lot of new API!).

Chris.

p.s god damn memory leaks! lol

[PrincieD]

Just updating the docs now guys, not long now

Chris.

[PrincieD]

All the docs are complete now, just a couple of little things left to fix but i'm gunna leave it until tomorrow as i'm pretty tired now (haven't been to bed yet since yesterday lol)

Chris.

[PrincieD]

Finally! V1.20 is released, see top of thread

[Marco2007]

Very cool! Thx!

Thanks for SaveRebarLayout() and LoadRebarLayout()
It would be perfect, if the state of ShowRebarBand() would be included....