Page 3 of 3
Re: Betterlook.pbi - Make your PB app UI better-looking (WIP - Windows x64)
Posted: Fri Jun 02, 2023 3:12 pm
by ebs
Another suggestion: use #PB_Any to generate the IDs for the titlebar minimize/restore and close gadgets, rather than using fixed numbers (595, 596).
This should probably also be done for font IDs, image IDs, etc., so that the fixed numbers don't conflict with other gadgets.
Re: Betterlook.pbi - Make your PB app UI better-looking (WIP - Windows x64)
Posted: Fri Jun 02, 2023 3:13 pm
by Axolotl
After a brief look, I would like to make some suggestions, if you don't mind.
I like using named enumerations, especially in includes to avoid Gadget + 99 situations.
Code: Select all
Enumeration EWindow ; <-- my style E for enumeration, just like T in Structure TData for Type (but Name can be any different)
#WINDOW_Main
EndEnumeration
Enumeration EGadget
#GADGET_Panel
#GADGET_Text_on_Tab1 ; ...
#GADGET_Text_on_Tab2 ; ...
#GADGET_Text2_on_Tab2 ; ...
EndEnumeration
There is a small bug in WindowHandlerML().
You are using 0 instead of the parameter g for the procedure calls.
Examples work because the parameter is 0.
Re: Betterlook.pbi - Make your PB app UI better-looking (WIP - Windows x64)
Posted: Sat Jun 03, 2023 10:44 am
by firace
Axolotl, ebs: thanks for your feedback! I will definitely look into these issues.
(Just need to take a few days off now)