It is currently Tue Jan 26, 2021 5:35 am

All times are UTC + 1 hour




Post new topic Reply to topic  [ 26 posts ]  Go to page 1, 2  Next
Author Message
 Post subject: [Done] EditorGadget regression
PostPosted: Sun Nov 15, 2020 7:39 am 
Offline
Addict
Addict

Joined: Thu Apr 18, 2019 8:17 am
Posts: 1211
[Edit] Post edited to show the problem in as little a snippet as possible.

The EditorGadget with 5.73 Beta 4 can't add lines ending with a plus, but it works with 5.72:

Code:
OpenWindow(0,200,200,100,100,"test",#PB_Window_SystemMenu)
EditorGadget(0,10,10,80,80)
AddGadgetItem(0,-1,"+-+")
AddGadgetItem(0,-1,"WTF")
Repeat : Until WaitWindowEvent()=#PB_Event_CloseWindow

Image


Last edited by BarryG on Sun Nov 15, 2020 2:15 pm, edited 5 times in total.

Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 7:55 am 
Offline
Enthusiast
Enthusiast
User avatar

Joined: Sun Jun 11, 2006 12:07 am
Posts: 587
Location: Near Hamburg
Hi Barry,

It doesn't look like the procedure for filling the editor gadget is complicated. Why can't you provide a code snippet for the example?
Maybe it has to do with escaping strings and a certain combination of / and \ leads to the problem. It is certainly tedious for Fred to type your whole maze pattern by hand.

Markus

_________________
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 52y
"Happiness is a pet." | "Never run a changing system!"


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 8:10 am 
Offline
Addict
Addict

Joined: Thu Apr 18, 2019 8:17 am
Posts: 1211
Updated with a snippet to show the regression.


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 10:06 am 
Offline
Enthusiast
Enthusiast
User avatar

Joined: Sun Jun 11, 2006 12:07 am
Posts: 587
Location: Near Hamburg
Cool, thanks. I have just installed Beta 4 and tried your snippet from the first post.
But, I cannot confirm the problem.

It really seems to be only a certain constellation of \ and / chars. Does the problem occur with every startup?

_________________
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 52y
"Happiness is a pet." | "Never run a changing system!"


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 11:00 am 
Offline
Always Here
Always Here

Joined: Sun Sep 07, 2008 12:45 pm
Posts: 5213
Location: Germany
Hm...

This:
Code:
OpenWindow(0,200,200,200,100,"test",#PB_Window_SystemMenu)
EditorGadget(0,10,10,180,80)

AddGadgetItem(0,-1,"+----------+")
AddGadgetItem(0,-1,"| C64 Maze |")
AddGadgetItem(0,-1,"+----------+")

Repeat : Until WaitWindowEvent()=#PB_Event_CloseWindow

results in:
Image

So it is not a problem of \ escape.
Maybe there is a hidden 'boxdrawing feature' in richedit.

PB 5.73B4 x86 on Win10 20H2 x64


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 11:27 am 
Offline
Addict
Addict

Joined: Thu Apr 18, 2019 8:17 am
Posts: 1211
kurzer, yes, it occurs every time. A totally different output with 5.73 Beta 4 to 5.72. infratec's example shows it, too.

I'm worried about using 5.73 now, as this is the second regression I've found. Makes me wonder what else is different that I haven't found yet.


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 11:28 am 
Offline
Enthusiast
Enthusiast
User avatar

Joined: Sun Jun 11, 2006 12:07 am
Posts: 587
Location: Near Hamburg
@infratec: But then it must depend on something else.
I still cannot reproduce it.

OS = Win 7x64

Image

_________________
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 52y
"Happiness is a pet." | "Never run a changing system!"


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 11:52 am 
Offline
Addict
Addict

Joined: Thu Apr 18, 2019 8:17 am
Posts: 1211
Infratec and I are on Win 10, and you're on Win 7.


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 12:21 pm 
Offline
Always Here
Always Here

Joined: Sun Sep 07, 2008 12:45 pm
Posts: 5213
Location: Germany
As I wrote: I think it is a 'feature' of the rich edit component.

In windows this is part of the OS.
But still, it works with 5.72, so it can be an initialization problem of rich edit in the newer version of the OS.


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 12:22 pm 
Offline
Enthusiast
Enthusiast
User avatar

Joined: Sun Jun 11, 2006 12:07 am
Posts: 587
Location: Near Hamburg
Oh okay, unfortunately my Win10 computer was destroyed by a power failure 5 days ago. Can't test it right now under Win 10.

_________________
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 52y
"Happiness is a pet." | "Never run a changing system!"


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 12:38 pm 
Offline
Addict
Addict

Joined: Thu Apr 18, 2019 8:17 am
Posts: 1211
infratec wrote:
it can be an initialization problem of rich edit in the newer version of the OS.

But that wouldn't explain why the problem goes away with a space after the plus character?


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 12:47 pm 
Offline
Addict
Addict

Joined: Thu Jun 07, 2007 3:25 pm
Posts: 3967
Location: Berlin, Germany
infratec wrote:
But still, it works with 5.72, so it can be an initialization problem of rich edit in the newer version of the OS.

In one of the PB 5.73 beta versions (I don't recall in which one exactly), Fred changed the editor gadget so that it uses msftedit.dll instead of Riched20.dll, see https://www.purebasic.fr/english/viewtopic.php?p=561335#p561335.
It seems that we are now experiencing the "features" of msftedit.dll. :|

_________________
Please excuse my flawed English. My native language is PureBasic.
Search
RSBasic's backups


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 1:05 pm 
Offline
Addict
Addict

Joined: Thu Apr 18, 2019 8:17 am
Posts: 1211
That'd be it! Damn, that's no good then. The user must be able to specify whichever text he wants in the EditorGadget, without it being changed to something unintended.


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 1:50 pm 
Offline
Always Here
Always Here

Joined: Sun Sep 07, 2008 12:45 pm
Posts: 5213
Location: Germany
Maybe interresting:

http://www.jose.it-berater.org/richedit ... ontrol.htm

At the end it is a table what is different from msftedi (RichEdit 4.1) to riched20 (RichEdit 3.0)


Top
 Profile  
Reply with quote  
 Post subject: Re: EditorGadget regression
PostPosted: Sun Nov 15, 2020 2:13 pm 
Offline
Enthusiast
Enthusiast
User avatar

Joined: Sun Jun 11, 2006 12:07 am
Posts: 587
Location: Near Hamburg
Confirmed.

I have now tested it in a Win10 virtual machine.
This seems to be the table feature, because you can enlarge the frame with the mouse. :shock:

Image

_________________
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 52y
"Happiness is a pet." | "Never run a changing system!"


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 26 posts ]  Go to page 1, 2  Next

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
Jump to:  

 


Powered by phpBB © 2008 phpBB Group
subSilver+ theme by Canver Software, sponsor Sanal Modifiye