PB 5.70 - DesktopScaled Bug

diskay · **Joined:** Sun Aug 02, 2015 7:17 pm **Posts:** 13

Code:

;%125
dpi = 96*1.25

; =913
Debug MulDiv_(730, dpi, 96)

; =912
Debug DesktopScaledX(730)

It's 1 pixel less than normal

Little John · **Posted:** Wed Jan 30, 2019 11:13 am

730 * 120 / 96 = 912.5

MulDiv_() rounds the result up.
DesktopScaledX() rounds the result down.
I'd hardly call that a bug.

Justin · **Joined:** Sat Apr 26, 2003 2:49 pm **Posts:** 589

It should have an optional round parameter or follow muldiv() wich is everyione uses.

diskay · **Joined:** Sun Aug 02, 2015 7:17 pm **Posts:** 13

Justin wrote:

It should have an optional round parameter or follow muldiv() wich is everyione uses.

MulDiv is Microsoft's approach

Justin · **Joined:** Sat Apr 26, 2003 2:49 pm **Posts:** 589

Exactly, and it's what the os uses when automatically scales fonts and windows.

Try to get the scaled os system font height, the pb function fails because it rounds down.

But the best alternative is add an optional round parameter, rounding up or down makes difference and should be up to the programmer what to use.

Little John · **Posted:** Thu Jan 31, 2019 8:48 pm

diskay wrote:

MulDiv is Microsoft's approach

Justin wrote:

Exactly, and it's what the os uses when automatically scales fonts and windows.

I see. That makes sense.

Justin · **Joined:** Sat Apr 26, 2003 2:49 pm **Posts:** 589

Spam?

PureBasic Forum

PB 5.70 - DesktopScaled Bug

Who is online