It is currently Tue Jun 02, 2020 7:55 pm

All times are UTC + 1 hour




Post new topic Reply to topic  [ 5 posts ] 
Author Message
 Post subject: GoScintilla for PB 5.x
PostPosted: Mon Jan 02, 2017 9:08 pm 
Offline
Enthusiast
Enthusiast
User avatar

Joined: Thu Nov 26, 2015 6:52 pm
Posts: 178
Location: Italy
GoScintilla for PB >= 5.10

Just wanted to inform everyone that I’ve published an updated version of Stephen’s GoScintilla, compatible with PureBASIC 5.x:


  • The changes required to make it compatible with PB 5.x brake its backward compatibility with PureBASIC versions < 5.10.
  • For this reason I've changed its version number to 3.0.0 (following Semantic Version 2.0 standard, which is customary on GitHub).
  • No new features added, just fixed GoScintilla.pbi to work with PB 5.x.

I want to thank Stephen (srod) for permission to go ahead with this project.


All contributions are welcome.

B.R.

Tristano

Post Sscriptum

After consulting with GoScintilla's author, I wanted to emphasize that version 3 in my fork of GoScintilla only refers to the fact that it breaks backward compatiblity.
IT DOESN'T MEAN that it adds new features — it doesn't (not yet at least).

I've changed its MAJOR version number because on GitHub is customary to follow Semantic Versioning 2.0 standard:

Quote:
8) Major version X (X.y.z | X > 0) MUST be incremented if any backwards incompatible changes are introduced to the public API. It MAY include minor and patch level changes. Patch and minor version MUST be reset to 0 when major version is incremented.


I apologize if this lead to any confusion, I didn't mean to give the impression that I had introduced new features; I only wanted to distribute an updated version that works with current PB 5.x.

I've now also renamed the project folder from "GoScintilla3" to "GoScintilla", to de-emphasize the version number; and now refer to it just as GoScintilla for PB5.x in the documentation. References to its being v3.0 are kept along with explanation why I changed it.

_________________
The PureBASIC Archives:
FOSS Resources:


Last edited by Tristano on Tue Jan 03, 2017 3:03 pm, edited 3 times in total.

Top
 Profile  
Reply with quote  
 Post subject: Re: GoScintilla 3 — for PB 5.x
PostPosted: Mon Jan 02, 2017 11:06 pm 
Offline
PureBasic Expert
PureBasic Expert

Joined: Wed Oct 29, 2003 4:35 pm
Posts: 10587
Location: Beyond the pale...
Tristano, the current version of GoScintilla (2.7) seems to work fine with PB 5.51 x86. Is there something I am missing?

Otherwise I am happy for you to do what you wish with the code.

_________________
I may look like a mule, but I'm not a complete ass.


Top
 Profile  
Reply with quote  
 Post subject: Re: GoScintilla 3 — for PB 5.x
PostPosted: Tue Jan 03, 2017 12:17 am 
Offline
Always Here
Always Here
User avatar

Joined: Thu Jun 24, 2004 2:44 pm
Posts: 5755
Location: Berlin - Germany
@srod
I have only tested to first error: #PB_Sort_String

Greetings
Thomas

_________________
PureBasic 5.71 | SpiderBasic 2.30 | Windows 10 Pro (x64) | Linux Mint 19.3 (x64)
Old bugs good, new bugs bad! Updates are evil: might fix old bugs and introduce no new ones.
Image


Top
 Profile  
Reply with quote  
 Post subject: Re: GoScintilla 3 — for PB 5.x
PostPosted: Tue Jan 03, 2017 9:14 am 
Offline
PureBasic Expert
PureBasic Expert

Joined: Wed Oct 29, 2003 4:35 pm
Posts: 10587
Location: Beyond the pale...
Ah, memory is getting faulty in my old age. I adjusted the code some time ago so that it was compatible with PB 5.5x and plain forgot about it!

Doh! :)

_________________
I may look like a mule, but I'm not a complete ass.


Top
 Profile  
Reply with quote  
 Post subject: Re: GoScintilla for PB 5.x
PostPosted: Tue Jan 03, 2017 12:10 pm 
Offline
Enthusiast
Enthusiast
User avatar

Joined: Thu Nov 26, 2015 6:52 pm
Posts: 178
Location: Italy
Yes, there were 3 lines of code which I had to change for it to work with PB5.x.

Line 108, "Native types can't be used with pointers" (now: *bytePointer):

Code:
        *bytePointer.i              ;Used for left delimiters (separators).


Line 1787, "Constant not found: #PB_Sort_String" (now: #PB_String):

Code:
        SortStructuredList(*this\Keywords(), #PB_Sort_Ascending|t1, OffsetOf(GoScintillaKeyword\keyWord$), #PB_Sort_String)


Line 1853 (same as above):

Code:
       SortStructuredList(*this\Keywords(), #PB_Sort_Ascending|t1, OffsetOf(GoScintillaKeyword\keyWord$), #PB_Sort_String)


Both these errors refer to changes brought in with PureBasic release 5.10:

http://www.purebasic.com/documentation/ ... story.html

Quote:
14th February 2013 : Version 5.10
- Changed: replaced #PB_Sort_<Type> with #PB_<Type> to avoid possible errors
- Changed: disallow native type for pointers


So, these 3 small changes I've made are making GoScintilla work with PB >= 5.10, and break its compatiblity with PB <5.10.

Hence, I opted to update its version number to 3.0.

_________________
The PureBASIC Archives:
FOSS Resources:


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 6 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
Jump to:  

 


Powered by phpBB © 2008 phpBB Group
subSilver+ theme by Canver Software, sponsor Sanal Modifiye